Rename docker-entrypoint to container-entrypoint#59
Merged
rwaffen merged 8 commits intoOpenVoxProject:mainfrom Aug 15, 2025
Merged
Rename docker-entrypoint to container-entrypoint#59rwaffen merged 8 commits intoOpenVoxProject:mainfrom
rwaffen merged 8 commits intoOpenVoxProject:mainfrom
Conversation
nsballmann
reviewed
Jul 30, 2025
nsballmann
reviewed
Jul 30, 2025
nsballmann
reviewed
Jul 30, 2025
nsballmann
reviewed
Jul 30, 2025
nsballmann
reviewed
Jul 30, 2025
Sebastian-Maier
force-pushed
the
refactor/container-entrypoint
branch
from
2fba4de to
8dbaf8a
Compare
Member
|
i enabled the ci for your pr. nice work and good to see a lively discussion. keep up the good work. will review in detail later. one thing: please sign your commits :) |
…sh}; adjust scripts and readme Signed-off-by: Sebastian Maier <sebastian.maier@siemens.com>
Signed-off-by: Sebastian Maier <sebastian.maier@siemens.com>
…ner-entrypoint.d/ Signed-off-by: Sebastian Maier <sebastian.maier@siemens.com>
Signed-off-by: Sebastian Maier <sebastian.maier@siemens.com>
Signed-off-by: Sebastian Maier <sebastian.maier@siemens.com>
Sebastian-Maier
force-pushed
the
refactor/container-entrypoint
branch
from
8dbaf8a to
577f134
Compare
Contributor
Author
The commits of the PR are now signed with GPG. |
rwaffen
approved these changes
Aug 15, 2025
Member
|
LGTM, asked the other @OpenVoxProject/container-maintainers to also review, because its a big one |
bastelfreak
approved these changes
Aug 15, 2025
|
@Sebastian-Maier thank you for implementing this. @rwaffen @bastelfreak thank you for reviewing and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #56 by using vendor-agnostic "container" terminology instead of "Docker" (in a backwards-compatible fashion):
container-entrypoint.shthat supports custom scripts in both/docker-custom-entrypoint.d/and/container-custom-entrypoint.d/directoriesdocker-entrypoint.shto print a deprecation warning and callcontainer-entrypoint.sh